refactor: fix i18n bug in node v22 #10129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Problem noticed in #10119
Note: we are not yet using Node v22 in the CI due to a v8 bug.
Unit tests do not pass under Node v22 due to a Intl behavior change. I don't know if it's a bug or if it's due to respecting the spec more strictly.
I fix this issue here, so that I can still use Node 22 locally.
Test Plan
unit tests