Migrate from Azure Pipelines to GitHub Actions #13222
Merged
+115
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beyond just a pure migration, this also: - Drops Node 14 usage from CI (which also removes the need for explicit npm 8 installs) - Removes the "old node" test, which just checked that installing on old node failed. We shouldn't need to test that - Consolidates the build & test workflows so we don't end up with a proliferation of workflows.
|
Azure pipelines is no longer running, so I'm going to land this for some parity (and improvement). FWIW I am not stepping up to maintain this project - this is a one-off cleanup to move off of Azure. |
|
bb |
unional
pushed a commit
to unional/create-react-app
that referenced
this pull request
Feb 21, 2024
Beyond just a pure migration, this also: - Drops Node 14 usage from CI (which also removes the need for explicit npm 8 installs) - Removes the "old node" test, which just checked that installing on old node failed. We shouldn't need to test that - Consolidates the build & test workflows so we don't end up with a proliferation of workflows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beyond just a pure migration, this also:
You can see this run here from my fork (in a different branch, before squashing for the PR): https://github.com/zpao/create-react-app/actions/runs/5226343675
Also, while I dropped Node 14, I didn't include Node 18. I tried but one job failed for some reason and it wasn't worth figuring out. It's trivial to add with the matrix setup.