Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(buck2_common): don't overload the user with HTTP retry backoff warnings #342

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

refactor(buck2_common): don't overload the user with HTTP retry backoff warnings #342

wants to merge 5 commits into from

Commits on Jul 14, 2023

  1. buck2_data: add DispatchableHttpRetryWarning 

    Summary: Used in an upcoming diff to replace noisy warnings on stdout.

Signed-off-by: Austin Seipp <aseipp@pobox.com>
Change-Id: Ia17005d526a72e0a444b713ebc93f200
    @thoughtpolice
    thoughtpolice committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    d65f158 View commit details
    Browse the repository at this point in the history

  2. buck2_common: thread DispatchableHttpRetryWarning into the API 

    Summary: NFC. This just sets up everything so that the normal HTTP materializer
and the Manifold client can have different retry warnings enabled in an upcoming
change.

Signed-off-by: Austin Seipp <aseipp@pobox.com>
Change-Id: Iaac8ffce8ec20563216eaf4de1b98206
    @thoughtpolice
    thoughtpolice committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    9f3438d View commit details
    Browse the repository at this point in the history

  3. buck2_client_ctx(manifold): create ManifoldDispatchableHttpRetryWarning 

    Summary: NFC. Wired up, but won't take effect yet.

Signed-off-by: Austin Seipp <aseipp@pobox.com>
Change-Id: I9ccb6647aed663b6823ad9f42119f8e1
    @thoughtpolice
    thoughtpolice committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    cf0ff12 View commit details
    Browse the repository at this point in the history

  4. buck2_execute(materializer): create MaterializerDispatchableHttpRetry… 

    …Warning

Summary: NFC. Wired up, but won't take effect yet.

Signed-off-by: Austin Seipp <aseipp@pobox.com>
Change-Id: I6d061db6956e2133e33a74d79bb2f583
    @thoughtpolice
    thoughtpolice committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    ef7fe55 View commit details
    Browse the repository at this point in the history

  5. buck2_common(http): wire up DispatchableHttpRetryWarning trait to fire 

    Summary: This switches both the materializer and the manifold client to use the
new interface, all at once.

Signed-off-by: Austin Seipp <aseipp@pobox.com>
Change-Id: I6d061db6956e2133e33a74d79bb2f583
    @thoughtpolice
    thoughtpolice committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    8cb4b78 View commit details
    Browse the repository at this point in the history