Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TMK] Add support to build on Mac M2 #1453

Closed
wants to merge 3 commits into from

Conversation

sahilx13
Copy link

Summary

Updates the TMK Makefile to add support for building on Mac M2 machines

Copy link
Contributor

@Dcallies Dcallies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting a PR!

Looks like the CI can't build with the new flags (as you suspected).

Check out the approach the PDQ makefile uses for this: #1016 / https://github.com/facebook/ThreatExchange/blame/main/pdq/cpp/Makefile

Moving the common flags into the top, and then using if statements (or just a comment...) to select the right one may be as best as we can do.

Let me know if you have the time to take a crack at this, or if this is as far as you can make with your current bandwidth!

@Dcallies
Copy link
Contributor

Dcallies commented Mar 1, 2024

Hey @sahilx13, I'm going to close this PR for inactivity, feel free to re-open if you still want to try and get it merged!

@Dcallies Dcallies closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants