[hma] address missing distance field on /for-hash/ result objects
#1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and match distance of for-hash
github-actions
bot
added
the
hma
Dcallies
approved these changes
Apr 1, 2023
| @@ -539,6 +540,13 @@ def _matches_for_hash( | |||
|
|
|||
| return match_objects | |||
|
|
|||
| def _distance_from_match_if_exits(match: IndexMatch) -> int: | |||
There was a problem hiding this comment.
blocking: Add a docstring explaining the compatibility issue and whether you think we should move to off-int distance at some future point. Feel free to shorthand to an instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Had to resolve a set of errors to get to the
for-hashapi issue (would normally be different PR but the first two are 1 liners)distanceto remove error forfor-hashAPITest Plan
Confirmed that with changes fetcher can get values from API for sample set and build index and with the python code change that a valid matches data will return.