[RFC][HMA-in-a-bottle] Possible example of creating a modular matcher #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the matcher, and decoupling it from the cli code
github-actions
bot
added
the
python-threatexchange
added 2 commits
March 29, 2023 22:44
… of the matcher, and decoupling it from the cli code
…ge into hma-in-a-bottle
| # Supposed to be without whitespace, but let's make sure | ||
| distance_str = "".join(r.similarity_info.pretty_str().split()) | ||
| print( | ||
| # s_type.get_name(), |
There was a problem hiding this comment.
hmm, knowing the type matched is valuable. One options though I'm not sure it is worth the overhead is to have it as part of the metadata(s)
There was a problem hiding this comment.
Yeah, agreed, and something that we/I need to come back to. I commented it out for now as it didn't exist in this scope, and didn't want to forget that I removed it.
dougneal
reviewed
Mar 30, 2023
|
|
||
| class Matcher(t.Generic[T]): | ||
| # question (sa) -- how do we want to handle the settings? In the CLI it's considered | ||
| # a god object -- do we want to pass it to the init of the class? |
dougneal
reviewed
Mar 30, 2023
| ) -> t.Sequence[IndexMatch]: | ||
| raise NotImplementedError | ||
|
|
||
| def _get_indicies(self) -> t.List[t.Tuple[t.Type[SignalType], SignalTypeIndex]]: |
|
Nice, this is pretty much what I had in mind also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An example of decoupling the matcher logic from the CLI into its own module and generic base class which allows for creation of specific matcher 'types' -- this was the simplest way to separate the logic for file matching and raw hash matching.
Test Plan
This is an RFC, but ran it locally and it all works.