Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pytx] devcontainer: install pip "extras" for development #1293

Merged
merged 1 commit into from
Mar 28, 2023
Merged

[pytx] devcontainer: install pip "extras" for development #1293

merged 1 commit into from
Mar 28, 2023

Conversation

dougneal
Copy link
Contributor

Summary

Install the dev dependencies as defined in the setup.py - pytest, black, and so on.

Test Plan

Rebuild devcontainer and check for presence of pytest command.

@dougneal dougneal marked this pull request as ready for review March 28, 2023 20:41
@dougneal dougneal requested a review from Dcallies as a code owner March 28, 2023 20:41
@dougneal dougneal merged commit 1a3f630 into facebook:main Mar 28, 2023
6 checks passed
@dougneal dougneal deleted the pytx-devcontainer-pipdevextras branch March 28, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BarrettOlson BarrettOlson BarrettOlson approved these changes

@Dcallies Dcallies Awaiting requested review from Dcallies Dcallies is a code owner

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dougneal @BarrettOlson @facebook-github-bot