-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerize python-threatexchange #1291
Conversation
3e682ca
to
bb5d910
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! here on in another PR I think it is worth updated the README.md with details/expected usage
bb5d910
to
d433cbf
Compare
The README changes got stuck on my machine. Fixed |
d433cbf
to
acb3046
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't use a lot of docker - what does this allow that users might like?
acb3046
to
983655e
Compare
The value to the user is that they don't have to be Python developers to run it, or even care about their Python install at all. Just If we were to publish the Docker image to the Docker hub or another container registry, they wouldn't even need the build step, just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So close! Just need to run black!
983655e
to
0504560
Compare
* Define a basic Docker container based on the official Python container * Enable persistent config and state with a Docker volume * Make the state dir configurable via environment variable `TX_STATEDIR`
0504560
to
76b9707
Compare
Summary
Reduce user friction by providing a Docker container for the CLI. This eliminates the need for the user to have to care about Python.
To make for a clean Docker image layout, the persistent state directory is now configurable. While the default remains
~/.threatexchange
, it can now be overridden by setting aTX_STATEDIR
environment variable.Test Plan