Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[py-tx] Align tx match --hash format with the output of tx hash #1289

Closed
wants to merge 5 commits into from
Closed

[py-tx] Align tx match --hash format with the output of tx hash #1289

wants to merge 5 commits into from

Commits on Mar 28, 2023

  1. Fix for Issue 1188. This diff allows for the usage of the hash format… 

    … produced by the hash command to be used in the match command (i.e. prefixed with 'pdq'). In addition, allows for multiple hashes in a single file of varying signal types. Will throw exceptions when you specify (-S) a signal type, and provide hashes of another type, as well as when there are multiple signal type prefixes with a mixture of no prefixes -- i.e. when we are unable to 'infer' the signal type from the hash
    Sam Freeman committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    7c15da7 View commit details
    Browse the repository at this point in the history

  2. Fix for Issue 1188. This diff allows for the usage of the hash format… 

    … produced by the hash command to be used in the match command (i.e. prefixed with 'pdq'). In addition, allows for multiple hashes in a single file of varying signal types. Will throw exceptions when you specify (-S) a signal type, and provide hashes of another type, as well as when there are multiple signal type prefixes with a mixture of no prefixes -- i.e. when we are unable to 'infer' the signal type from the hash
    Sam Freeman committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    df11f53 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'issue-1188' of github.com:Sam-Freeman/ThreatExchange in… 

    …to issue-1188
    Sam Freeman committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    36fd805 View commit details
    Browse the repository at this point in the history

  4. Formatting and fix for typing (with mypy)

    Sam Freeman committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    7230c21 View commit details
    Browse the repository at this point in the history

  5. Synced up with David offline. Addressed comments, and restructured so… 

    …me of the code.
    Sam Freeman committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    09ea93c View commit details
    Browse the repository at this point in the history