Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Added e2e test info in the main commons repository. #622

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Preeticp
Copy link
Contributor

@Preeticp Preeticp commented Sep 6, 2018

Added end to end tests in the Commons repo. This information was part of the Deployment repo here: https://github.com/fabric8-analytics/fabric8-analytics-deployment/tree/master/openshift#e2e-test

@Preeticp
Copy link
Contributor Author

Preeticp commented Sep 6, 2018

@tisnik, @msrb I have 3 questions:

  1. Please review the second step in the procedure.
    I have changed the text from the original here: https://github.com/fabric8-analytics/fabric8-analytics-deployment/tree/master/openshift#e2e-test
    Please let me know if it needs to be modified.
  2. We ask the user to modify the env.sh file, but it is not part of the Commons repo, so we may want to provide a link to it(deployment repo). Or is there any other way to go about it?
  3. In addition, we might want to add these instructions to this section:
    $ cp env-template.sh env.sh
    $ vim env.sh
    These instructions are currently here: https://github.com/fabric8-analytics/fabric8-analytics-deployment/tree/master/openshift#configure-fabric8-analytics-services
    WDYT?

@tisnik
Copy link
Member

tisnik commented Sep 7, 2018

1+2. You can just write: configure the .... variable. It's up to the user how/where to configure it. I use export RECOMMENDER_API_TOKEN=xyz for example

@tisnik tisnik self-requested a review July 13, 2020 09:15
Copy link
Member

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK (but it is very old PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants