default host key policy to RejectPolicy #2280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a really bad idea to silently accept new keys. It's not how SSH works, and it's not how Fabric *should* work. If we'd work like SSH, we'd *prompt* the user, but the WarningPolicy doesn't do that, it just warns, and doesn't prompt. At the very least those policies should noisily warn the user when the host keys get changed, but that's something Paramiko must do. An alternative to this would be WarningPolicy but I think it's too light and possibly too late: when you warn, Fabric probably has time to run the bad stuff before the operator notices and interrupts.
anarcat
force-pushed
the
host-keys-reject
branch
from
c7ef1dd
to
083552c
Compare
This was referenced Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a really bad idea to silently accept new keys. It's not how SSH works, and it's not how Fabric should work. If we'd work like SSH, we'd prompt the user, but the WarningPolicy doesn't do that, it just warns, and doesn't prompt.
At the very least those policies should noisily warn the user when the host keys get changed, but that's something Paramiko must do.
An alternative to this would be WarningPolicy but I think it's too light and possibly too late: when you warn, Fabric probably has time to run the bad stuff before the operator notices and interrupts.