forward_local() does not work on windows. #2221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tunnel.py code should handle BlockingIOError happening on windows when try to call forward_local()
|
Hey, this is nice -- it works for me (until the function its called from ends) |
|
Late to the party, but this was fixed in this commit already on main: 47e3cd5. I think it's available on version 3.0.0 onwards. |
bitprophet
force-pushed
the
main
branch
2 times, most recently
from
67e9029
to
21b24d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tunnel.py code should handle BlockingIOError happening on windows when try to call forward_local()
More discussed on the below issue reported. @nitrocalcite found the fix, cudos to him
#2102