Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing old pytest upper limit #2193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elreydetoda
Copy link

@elreydetoda elreydetoda commented Jan 27, 2022

I was trying to pull in pytest-mock and pytest-xdist (since I won't only be using pytest for fabric parts of my code and I'll need these for other things), and they both have lower limits of pytest at 5.0 and 6.2.0.

So, when trying to install fabric's pytest (fabric[pytest]) as well I wasn't able to get a version of pytest to match.

image

Pytest 5.0.0 was released in Jun 28, 2019, so 4.0 is quite an old release. If your comfortable with just removing the upper bounds for pytest, then it should be able to reach a consensus between the packages. So, I just removed the upper bounds with this PR, but if you don't want to do that then you'll have to keep on top of this every time the upper bounds gets old.

Seems like it was probably just put in there since it was the latest major release: b98334b

Haven't used the project really yet, but seems pretty awesome! Thanks for your hard work!

@davidjmemmett
Copy link
Contributor

Hi @elreydetoda - I've just taken a look into this and it might not be as simple as relaxing this requirement - there is quite a bit of work to do in the other requirements files (dev-requirements.txt) and ensuring that the tests still pass before upgrading pytest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants