Use standard library unittest.mock on Python 3.6 and later #2168

musicinmybrain · 2021-06-03T23:36:42Z

Drop the dependency on PyPI mock beginning with Python 3.6, as it is entirely replaced by unittest.mock in the standard library.

While unittest.mock appeared in Python 3.3, we explicitly check that the Python version is at least 3.6 so that the assert_called() and assert_called_once() methods are available on the Mock class.

musicinmybrain · 2021-06-04T02:13:47Z

There are CI failures for reasons that appear unrelated to this PR.

Use standard library unittest.mock on Python 3.6 and later

e6ca97c

musicinmybrain changed the title ~~Use standard library unittest.mock on Python 3.6 and later~~ WIP: Use standard library unittest.mock on Python 3.6 and later Jun 3, 2021

Put conditional unittest.mock imports last to placate flake8

7fbf916

musicinmybrain changed the title ~~WIP: Use standard library unittest.mock on Python 3.6 and later~~ Use standard library unittest.mock on Python 3.6 and later Jun 4, 2021

bitprophet force-pushed the main branch 2 times, most recently from 67e9029 to 21b24d2 Compare August 31, 2023 01:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use standard library unittest.mock on Python 3.6 and later #2168

Use standard library unittest.mock on Python 3.6 and later #2168

musicinmybrain commented Jun 3, 2021

musicinmybrain commented Jun 4, 2021

Use standard library unittest.mock on Python 3.6 and later #2168

Are you sure you want to change the base?

Use standard library unittest.mock on Python 3.6 and later #2168

Conversation

musicinmybrain commented Jun 3, 2021

musicinmybrain commented Jun 4, 2021