[WIP] fable-core.js generation from TypeScript #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pt). Initial proof of concept: List and (partial) Seq class only.
|
Nice 👍 |
- Renames es2015-mini.ts to fable-core.tsc.ts
fdcastel
changed the title
Closed
| // TEMP: Builds fable-core.tsc.js from TypeScript sources. | ||
| // Requires 'npm install babel-preset-es2015' in src/fable/Fable.Core | ||
| "es2015-mini.ts --target ES2015 --outDir . --declaration" |> runWrapped "tsc" | ||
| "es2015-mini.js -o fable-core.tsc.js" |> runWrapped "babel" | ||
|
|
There was a problem hiding this comment.
oh oh... lines 274-278 shouldn't be here 😭
…fable-core - Fix conflicts with fable-compiler#241
…fable-core - Fix conflicts with fable-compiler#241 (again :) )
…ed) to fable-core.tsc.ts.
🎉 |
fdcastel
changed the title
| ys.[0] + ys.[1] | ||
| |> equal 3 | ||
| ys.[0] + ys.[1] + ys.[2] + ys.[3] + ys.[4] | ||
| |> equal 15. |
There was a problem hiding this comment.
Could you please add this as a different assertion instead of replacing the old one?
|
Done! Sorry, again. It's really better this way. |
|
Sorry, I tried to merge this but there're conflicts and when trying to rebase the branch with master I got some weird conflicts in the |
|
Looking at it now... |
|
Alea iacta est, I'm merging this 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial proof-of-concept to port
es2015.jsto TypeScript.Far from complete.
Listand (partial)Seqclasses only.To build: From project root folder, run:
tsc src/fable/Fable.Core/es2015-mini.ts --target ES2015 --outDir src/fable/Fable.Core --declarationThis will create
Discussion at #232