Skip to content

Commit

Permalink
Freeze command-line-args version
Browse files Browse the repository at this point in the history
Fix #871, #873
  • Loading branch information
Maxime Mangel committed May 7, 2017
1 parent b896982 commit 7d54076
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
5 changes: 0 additions & 5 deletions src/fable/Fable.Client.Node/ts/options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,6 @@ function readCommandLineOptions() {
return o;
}
var opts = commandLineArgs(optionDefinitions);
// Latest version of command-line-args doesn't set empty flags to true but null
for (var k in opts) {
if (opts[k] === null)
opts[k] = true;
}

This comment has been minimized.

Copy link
@alfonsogarciacaro

alfonsogarciacaro May 7, 2017

Member

Is it OK to remove this? I don't remember if setting empty flags to null started from command-line-args 4.0.1 or later.

This comment has been minimized.

Copy link
@alfonsogarciacaro

alfonsogarciacaro May 7, 2017

Member

Scratch that, I just tested it and it's fine :)

This comment has been minimized.

Copy link
@MangelMaxime

MangelMaxime May 7, 2017

Member

From my test this was fine without it. :)

if (opts.help) {
fableLib.stdoutLog(commandLineUsage(getAppDescription()));
fableLib.finish(0);
Expand Down
2 changes: 1 addition & 1 deletion src/fable/Fable.Client.Node/ts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"babel-traverse": "^6.23.1",
"babel-types": "^6.23.0",
"chokidar": "^1.6.1",
"command-line-args": "^4.0.1",
"command-line-args": "4.0.1",
"command-line-usage": "^4.0.0",
"json5": "^0.5.1",
"resolve": "^1.3.2",
Expand Down

0 comments on commit 7d54076

Please sign in to comment.