Remove left-overs of code completion in breakpoint properties #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Just applied. |
|
Hi @fabioz is it possible to create a new point release containing this and the other recently merged fixes? |
|
Yes, I'm also missing a release myself (I still didn't have the time to do it, but my plan is doing it soon). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eclipse 2024-03 removed some APIs that have been deprecated for several years. Some of these APIs have been used in the Breakpoint Property Editor to enable/disable the handlers used for code completion of conditional breakpoints. However, code completion for conditional breakpoints seems to have been commented out for > 18 years. So I went ahead and removed the commented code as well the usages of the deprecated APIs.
I know that a better but much more time consuming solution would have been to reimplement code completion, but I currently don't have the time to do this. Since the code completition wasn't working anyway, I believe that this change doesn't do any harm, but allows using PyDev with Eclipse 2024-03 onwards. In case someone wants to implement code completion again, the changes are still visible in the git history.