Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fake high-resolution turning setting #1691

Merged
merged 10 commits into from
May 22, 2024

Conversation

ceski-1
Copy link
Collaborator

@ceski-1 ceski-1 commented May 14, 2024

There have been a couple requests for this:
https://www.doomworld.com/forum/post/2776801
https://www.doomworld.com/forum/post/2790719

When smooth_shorttics is enabled, the view angle appears to move smoothly when using shorttics. The catch is that the true angle is actually somewhere within +/-0.7 degrees of this value. It would be nice to get some feedback from players to see if this is too disorienting.

Example (the menu items are placeholders, but maybe they're nice to have):

smooth_shorttics.mp4

@ceski-1 ceski-1 force-pushed the smooth_shorttics branch 4 times, most recently from ba8f781 to 2efb9e5 Compare May 17, 2024 16:44
@rfomin
Copy link
Collaborator

rfomin commented May 18, 2024

Crashes when run without `-warp' command.

I like the idea.

@Big-the-Fat
Copy link

I've been trying it out and haven't felt any issues. Sorry I can't give specific details. I think for changes like this 'feel' is important and I can't say that the feel is negatively impacted. Oh, I play with a wired DS4 through DS4Windows so that might have some impact. I dunno about any of this stuff, though. I just thought I'd chip in since there hasn't been much response from others. :)

@ceski-1
Copy link
Collaborator Author

ceski-1 commented May 18, 2024

@Big-the-Fat Thanks for the feedback! It works the same way for mouse or gamepad. I can tell the difference between "smooth" shorttics and actual longtics, but if most people can't then it'll be fine for casual play. Speedrunners more than likely would prefer "coarse" shorttics for executing tricks consistently and won't use this setting.

@ceski-1 ceski-1 force-pushed the smooth_shorttics branch 2 times, most recently from 7488e6f to 6832d0a Compare May 19, 2024 15:25
@ceski-1
Copy link
Collaborator Author

ceski-1 commented May 19, 2024

Test wad to demonstrate a worst case scenario: shoot_the_button.zip

src/g_game.c Outdated Show resolved Hide resolved
@ceski-1 ceski-1 changed the title Add smooth low-resolution turning Add fake high-resolution turning setting May 21, 2024
@ceski-1 ceski-1 marked this pull request as ready for review May 21, 2024 06:22
Copy link
Collaborator

@rfomin rfomin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me, thank you.

src/p_pspr.c Outdated Show resolved Hide resolved
@ceski-1 ceski-1 merged commit 62ddc5c into fabiangreffrath:master May 22, 2024
6 checks passed
@ceski-1 ceski-1 deleted the smooth_shorttics branch May 22, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants