fix -fastdemo with -skipsec

[rfomin]

Fix #1307

[MrAlaux]

This fixes -skipsec for me. However, using -warp still disables fast playback, but weirdly enough, using both -warp and -skipsec together doesn't disable it.

[fabiangreffrath]

This fixes -skipsec for me. However, using -warp still disables fast playback, but weirdly enough, using both -warp and -skipsec together doesn't disable it.

I think this is also needed:

--- a/src/p_setup.c
+++ b/src/p_setup.c
@@ -1559,7 +1559,11 @@ void P_SetupLevel(int episode, int map, int playermask, skill_t skill)
   if (playback_warp == map || playback_nextlevel)
   {
     if (!playback_skiptics)
+    {
       G_EnableWarp(false);
+      if (fastdemo)
+        I_SetFastdemoTimer(true);
+    }
 
     playback_warp = -1;
     playback_nextlevel = false;

[rfomin]

Wait, I remembered why I implemented it this way. @MrAlaux, did you know that you can enable fastdemo at any time during normal demo playback by pressing the "fast forward" key?
So the -fastdemo command line parameter only matters if you want to play the demo non-interactively.

[MrAlaux]

@MrAlaux, did you know that you can enable fastdemo at any time during normal demo playback by pressing the "fast forward" key?

I saw the key binding for it, but I never used it. Regardless, I think this should be fixed anyways.

[fabiangreffrath]

@rfomin how do we proceed here?

[rfomin]

@rfomin how do we proceed here?

Let's wait a bit. I don't remember the details and it needed testing.

I'm trying to fix the sky in Sigil 2 right now 😄

[fabiangreffrath]

This is still pending...

[rfomin]

This is still pending...

Let's postpone this even more 😄 It might not be worth fixing this - skipping a few levels with nodrawers and then continuing in fastdemo mode is not very useful. It might be worth refactoring playdemo and related functions. I wanted to revisit this after the menu and DRS changes.

[fabiangreffrath]

Oki.