-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/multiplayer things spawn options #1175
base: master
Are you sure you want to change the base?
Feature/multiplayer things spawn options #1175
Conversation
Option is available for all netgame types Added Multiplayer Things Spawn Type to setup menu Added Cmd Line Parameter mpspawntype Added netgame functionality Added mobjtype_weapons array is_weapon function Closes fabiangreffrath#681
Sorry, but before you put even more effort into this, it'd be only fair to tell you that I am not convinced of this concept and I am not going to merge it like this. The difference to DM3-support is that this added a single command line parameter and one or two more checks in the code. The approach here, however, adds a new command line parameter with different arguments and even modifies the netgame protocol. That's a no, sorry. The one feature that's been asked for is "coop without additional weapons", so I'd suggest to implement this and either call it |
Please try to restrict the amount of changes to the ones in this PR: |
@fabiangreffrath I would like to make less changes but I don't think it's feasible to both keep code clean and do it. src/doom/d_net.c
So Because of all that, I made a change to src/doom/d_net.c to convert a net deathmatch value to a global var and vice versa. I moved conditions to the separate functions to make code cleaner. netgame_modes_t boolean coop2 Please tell me, If you have any ideas how to make less changes and support high maintainability? |
@fabiangreffrath I additionally removed |
Option is available for all netgame types
Added Multiplayer Things Spawn Type to setup menu
Added Cmd Line Parameter mpspawntype
Added netgame functionality
Added mobjtype_weapons array is_weapon function
Closes #681
Options for Multiplayer Things Spawn Type are: