New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: docs and tests refactoring for minLength #416
base: main
Are you sure you want to change the base?
Conversation
Thank you for creating this issue. I want to figure out the use case first. I am not sure if we should really support length for numbers. Especially for pointing float numbers it can be confusing. I think |
It seems like |
@fabian-hiller good point, i was not going in detail regarding use case, but probably maxValue, minValue solve this and we keep minLength, maxLength for strings, arrays. I could rename the PRs and we keep the refactored tests and i add the docs in the same PR? |
Yes, sounds good! Thank you! |
b997a0f
to
6d0cde4
Compare
Referencing #396