Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIC PME-PMI Phi Value #1

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

TIC PME-PMI Phi Value #1

wants to merge 2 commits into from

Conversation

lupaulus
Copy link

I said last year, I would do the PR ! Here it is !

It's not much but honest work ;)

f00b4r0
f00b4r0 requested changes Jan 1, 2024
View reviewed changes
Copy link
Owner

@f00b4r0 f00b4r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your contribution, however I believe it is incomplete :)
In fact, it won't even build as you return an undefined token.
Handling TGPHI requires more work as it is expressed as a decimal value in TIC.

@lupaulus lupaulus marked this pull request as draft March 10, 2024 19:30
@lupaulus
Copy link
Author

We do some aditional work then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f00b4r0 f00b4r0 f00b4r0 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lupaulus @f00b4r0