Purs 0.15 #10
Merged
Purs 0.15 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
martyall
reviewed
Aug 27, 2023
package.json
Outdated
| @@ -14,8 +16,9 @@ | |||
| "solc": "^0.5" | |||
There was a problem hiding this comment.
what about this solc dep?
There was a problem hiding this comment.
package.json deps don't matter for purescript -- it's worth noting that this library allows you to invoke /any/ version of the solidity compiler (see the FFI in Compiler.js) -- the API was just stabilized in 0.5+
There was a problem hiding this comment.
(Releases.purs fetches/loads whatever version you want)
martyall
approved these changes
Aug 28, 2023
|
lgtm, excited about the tests |
martyall
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for Chanterelle.
Mostly routine, deps + CommonJS FFI.
Added purs-tidy and tidy-check to CI, as well as bumping the CI base image.
PureScript's change to ESM actually broke dynamically loading solc. There's a hack in here that requires Node v20.6+ to work, but it works. It did require a slight API change to
L.S.C.useCompilerAdded tests