Enable OTP 23 support with swappable native or Rust NIF keccack hash implementation #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- keccakf1600 doesn't compile on Erlang OTP 23 (potatosalad/erlang-keccakf1600#5)
rupurt
changed the title
|
@rupurt I fixed this in https://github.com/poanetwork/ex_abi |
|
@ayrat555 awesome, thank you. Have you tried to upstream it to the dependent libraries? |
|
No, but I think that's a good idea. I see only two libraries on hex.pm that depend on this version of Btw, |
|
Sweet. This was the lib I was trying to use when I ran into the underlying problem https://github.com/hswick/exw3. BTW cool to meet you @ayrat555 👋. Nice to see there is an active Elixir developer in the blockchain space 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Cannot build anymore on Erlang 23.0.2 and Elixir 1.10.3 potatosalad/erlang-keccakf1600#5)