Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReadME Example] - include file extension to save it properly #1156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcpeblocker
Copy link

Example was not working: files were being saved without their extension according to the example shown for DiskStorage

Example was not working: files were being saved without their extension according to the example shown for DiskStorage
@mcpeblocker mcpeblocker changed the title include file extension to save it properly [ReadME Example] - include file extension to save it properly Nov 7, 2022
@LinusU
Copy link
Member

LinusU commented Jan 11, 2023

Sorry for the late reply.

This is being done intentionally since it could be a security vulnerability to blindly use the extension provided by the client.

The client is free to send whatever extension it wants, and web-servers (or even just browsing the files with a file manager) could treat the file differently depending on the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants