Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add netlify logo as per their OSS license requirements #1511

Merged
merged 4 commits into from May 4, 2024

Conversation

jonchurch
Copy link
Member

@jonchurch jonchurch commented May 3, 2024

and also test the deploy previews

I setup netlify deploy previews, part of their deal for OSS is we get a free Pro plan with unlimited seats, and they get a plug on our homepage

Copy link

netlify bot commented May 3, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 06e3446
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/663693d1321be50008bac937
😎 Deploy Preview https://deploy-preview-1511--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonchurch
Copy link
Member Author

Cool, previews work! the logo isn't aligned so this shouldn't land yet, someone else can run with it if they want

@jonchurch jonchurch marked this pull request as draft May 3, 2024 01:51
@crandmck
Copy link
Member

crandmck commented May 3, 2024

The preview capability is great! Now I don't have to clone every fork/branch to see what it looks like--awesome!

But I'd like to suggest:

  • The logo should be a bit smaller so it's not quite so prominent. Do they require any particular size?
  • It should flow better with the existing footer.

Here's my suggestion:
Screenshot 2024-05-02 at 10 19 14 PM

What do you think?

This is done in _includes/footer-en.html like this:

  <div id="footer-content">
    <a href="https://www.netlify.com"> <img src="https://www.netlify.com/v3/img/components/netlify-color-accent.svg" alt="Preview Deploys by Netlify" 
      style="width: 50px;" /> </a>

@jonchurch
Copy link
Member Author

jonchurch commented May 3, 2024

LGTM

And just to be clear (for posterity), we are still hosting the site and deploying via github pages

Only previews are netlify, so "powered by netlify" isnt super true.

We also have the option to provide a link to netlify if we prefer not to use their badge

Add Netlify logo to footer as discussed
Moved Netlify logo to footer per discussion
@crandmck crandmck marked this pull request as ready for review May 4, 2024 17:17
@crandmck
Copy link
Member

crandmck commented May 4, 2024

OK, I made that change in your fork/branch @jonchurch . It was also a good trial of the deploy preview functionality. So nice.

Notes:

  • This is only for the English footer. Someone can add it to the other langs if they wish. Not required IMO.
  • Logo appears in the footer for ALL en pages, not just the home page. This is a side-effect of putting it in the footer. If anyone objects, we can look at alternatives.

@jonchurch
Copy link
Member Author

jonchurch commented May 4, 2024

good stuff

wrapped it in a div to give it a bit more spacing on mobile like the other footer items:

Screenshot 2024-05-04 at 4 05 52 PM

@jonchurch jonchurch merged commit 484ddb8 into expressjs:gh-pages May 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants