New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix nav links do not reappear after resizing #1502
base: gh-pages
Are you sure you want to change the base?
Conversation
@chrisdel101 Is this affected at all by your recent dark mode changes, or vice-versa? |
So I noticed this issue when I was working on that feature, but I recall I switched back to main ( |
clopened to see if it will trigger a build preview |
I honestly don't know why this works but it does |
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I looked into the overlay issue and fixed it using the same method that i used to fix the nav bar. It was working fine on my local system but I can't figure out the reason of 'deploy fail'. fixnav.mp4 |
The build is failing because Netlify is trying to use Jekyll build dependencies' README files, and at least one README has a malformed liquid directive:
This should be fixed by #1510 ... @aastha-cse Can you get the changes from that PR so we can preview this one? |
@jonchurch I'm seeing the media queries for the |
This is building now and the preview looks OK to me.... @jonchurch Do we need further changes or can we land this? |
Fixes #1499
The issue was with the toggling of display style between navmenu and overlay. To solve this I added a new class name 'open' that fixes the problem.
fixes.mp4