Fixed disappearing links #1420
Open
Fixed disappearing links #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The links were diaappearing due to the toggle method called on the #navmenu ul in jqeury, which let to an inline styling of display:none . Now when we click on hamburger menu in smaller width two times it first adds display block and then changes to none on the second click. Now as it is an inline css we can override it using !important. Files changed: 1. css/style.css Changes description: Added display: block !important on screen width being more than equal to 900px
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The links were diaappearing due to the toggle method called on the #navmenu ul in jqeury, which let to an inline styling of display:none . Now when we click on hamburger menu in smaller width two times it first adds display block and then changes to none on the second click. Now as it is an inline css we can override it using !important.
Files changed:
Changes description:
Added
display: block !important;on screen width being more than equal to 900pxIssue fixed: Link to the issue