Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add table of contents, tc/triager lists to readme #5619

Merged
merged 36 commits into from May 8, 2024

Conversation

mertcanaltin
Copy link
Member

@mertcanaltin mertcanaltin commented Apr 23, 2024

I have created a table and I think this place can provide convenience
In addition, I created areas introducing cooperation, technical committee, triagers.

added space for Code of Conduct

(unfortunately, some e-mails are missing, I couldn't find them :(
I could not add some people, I can add the missing participants 🙏)

@UlisesGascon @wesleytodd @CBID2

Readme.md Outdated Show resolved Hide resolved
Co-authored-by: krzysdz <krzysdz@users.noreply.github.com>
Readme.md Outdated Show resolved Hide resolved
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will suggest to add all the members from the teams before we merge the PR, so we avoid more PRs in the following days for additions/updates if possible.

Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
@UlisesGascon UlisesGascon added docs semver-ignore This change does not have any impact in semver (docs, tooling, etc..) labels Apr 23, 2024
mertcanaltin and others added 2 commits April 23, 2024 13:16
Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Copy link
Contributor

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mertcanaltin. There's still some parts that need improvement so I gave some suggestions to help you

Readme.md Outdated Show resolved Hide resolved
Readme.md Show resolved Hide resolved
Co-authored-by: Christine Belzie <105683440+CBID2@users.noreply.github.com>
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I think I have a very minor nit pick. I think this is better if each person is a single line. It makes it easier to follow changes imo. Not necessary to change, but imo would be better.

Copy link
Member

@aravindvnair99 aravindvnair99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have more triagers who are missing from the list including myself.

@mertcanaltin
Copy link
Member Author

I added the missing triagers
based on this list: https://github.com/orgs/expressjs/teams/triagers

Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
@jonchurch
Copy link
Member

related expressjs/discussions#230

Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
mertcanaltin and others added 2 commits May 3, 2024 16:45
Co-authored-by: Jon Church <me@jonchurch.com>
Co-authored-by: Jon Church <me@jonchurch.com>
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
jonchurch and others added 6 commits May 3, 2024 10:32
Co-authored-by: Jon Church <me@jonchurch.com>
Co-authored-by: Jon Church <me@jonchurch.com>
Co-authored-by: Jon Church <me@jonchurch.com>
Co-authored-by: Jon Church <me@jonchurch.com>
Co-authored-by: Jon Church <me@jonchurch.com>
@mertcanaltin
Copy link
Member Author

thank you @jonchurch ı accepted updates

@jonchurch jonchurch changed the title doc: updated readme file doc: add table of contents, tc/triager lists to readme May 4, 2024
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments and small changes 🔍

LGTM, thanks @mertcanaltin for the hard work on it!

Readme.md Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
Readme.md Show resolved Hide resolved
Readme.md Show resolved Hide resolved
Readme.md Show resolved Hide resolved
mertcanaltin and others added 5 commits May 5, 2024 18:29
Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Readme.md Show resolved Hide resolved
@jonchurch jonchurch merged commit 700349f into expressjs:master May 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs semver-ignore This change does not have any impact in semver (docs, tooling, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants