Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: path-to-regexp@0.1.8 #5603

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blakeembrey
Copy link
Member

Adds support for named capturing groups (pillarjs/path-to-regexp#301). Closes #4277.

@blakeembrey blakeembrey requested a review from a team April 16, 2024 21:33
Copy link
Member

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the HISTORY.md as with the other dependencies (see)?

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need new docs?

@blakeembrey
Copy link
Member Author

Should we update the HISTORY.md as with the other dependencies

Sure, I can model these PRs like prior commits if that's preferred. I'm just used to doing it retroactively with a release.

Do we need new docs?

I don't think it's necessary, it's pretty niche and most people are likely using the already working string based routing of /:name.

@blakeembrey blakeembrey changed the title Bump path-to-regexp deps: path-to-regexp@0.1.8 Apr 24, 2024
@blakeembrey
Copy link
Member Author

Sure, I can model these PRs like prior commits if that's preferred.

It may create conflicts in my PRs though 😓

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

named groups in regex routers not supported?
6 participants