feat: Add callback for configuring Vary header #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I enabled the CI to run in this PR 👍 |
jonchurch
reviewed
Apr 1, 2024
test/test.js
Outdated
| return true | ||
| } | ||
|
|
||
| if (req.originalUrl.startsWith('/images') && header === 'Origin') { |
There was a problem hiding this comment.
Node 0.10 failures are due to lack of .startsWith this language feature came in with ES6 in Node 6
There was a problem hiding this comment.
if (req.originalUrl.indexOf('/images') === 0 && header === 'Origin') {
indexOf should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #317
This PR adds a callback (
shouldSetVaryHeader) to the options which is used to determine when and how to configure the Vary header.To preserve backward compatibility with all existing
corsusages, this callback returnstrueby default.If this PR is accepted, I will add documentation to the README on how to use this PR's functionality.