fix: call underlying implementation properly

index.js

@@ -75,25 +75,40 @@ function compression (options) {
 
     // proxy
 
-    res.write = function write (chunk, encoding) {
+    res.write = function write (chunk, encoding, cb) {
       if (ended) {
         return false
       }
 
+      if (!cb && typeof encoding === 'function') {
+        cb = encoding
+        encoding = undefined
+      }
+
       if (!this._header) {
         this._implicitHeader()
       }
 
       return stream
-        ? stream.write(toBuffer(chunk, encoding))
-        : _write.call(this, chunk, encoding)
+        ? stream.write(toBuffer(chunk, encoding), encoding, cb)
+        : _write.call(this, chunk, encoding, cb)
     }
 
-    res.end = function end (chunk, encoding) {
+    res.end = function end (chunk, encoding, cb) {
       if (ended) {
         return false
       }
 
+      if (!cb) {
+        if (typeof chunk === 'function') {
+          cb = chunk
+          chunk = encoding = undefined
+        } else if (typeof encoding === 'function') {
+          cb = encoding
+          encoding = undefined
+        }
+      }
+
       if (!this._header) {
         // estimate the length
         if (!this.getHeader('Content-Length')) {
@@ -104,16 +119,16 @@ function compression (options) {
       }
 
       if (!stream) {
-        return _end.call(this, chunk, encoding)
+        return _end.call(this, chunk, encoding, cb)
       }
 
       // mark ended
       ended = true
 
       // write Buffer for Node.js 0.8
       return chunk
-        ? stream.end(toBuffer(chunk, encoding))
-        : stream.end()
+        ? stream.end(toBuffer(chunk, encoding), encoding, cb)
+        : stream.end(cb)
     }
 
     res.on = function on (type, listener) {

test/compression.js

@@ -10,6 +10,29 @@ var zlib = require('zlib')
 var compression = require('..')
 
 describe('compression()', function () {
+  it('request should end', function (done) {
+    var reponseText = 'hello, world'
+
+    var server = createServer({ threshold: 0 }, function (req, res) {
+      res.setHeader('Content-Type', 'text/plain')
+
+      res.write(Buffer.from(reponseText), (err) => {
+        if (err) {
+          console.error('err', err)
+        }
+
+        res.end()
+      })
+    })
+
+    request(server)
+      .get('/')
+      .set('Accept-Encoding', 'gzip')
+      .expect(shouldHaveHeader('Content-Encoding'))
+      .expect(shouldHaveBodyLength(reponseText.length))
+      .expect(200, done)
+  })
+
   it('should skip HEAD', function (done) {
     var server = createServer({ threshold: 0 }, function (req, res) {
       res.setHeader('Content-Type', 'text/plain')
@@ -680,6 +703,12 @@ function shouldHaveBodyLength (length) {
   }
 }
 
+function shouldHaveHeader (header) {
+  return function (res) {
+    assert.ok((header.toLowerCase() in res.headers), 'should have header ' + header)
+  }
+}
+
 function shouldNotHaveHeader (header) {
   return function (res) {
     assert.ok(!(header.toLowerCase() in res.headers), 'should not have header ' + header)