Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: qs@6.11.2 #521

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

deps: qs@6.11.2 #521

wants to merge 2 commits into from

Conversation

melikhov-dev
Copy link

@melikhov-dev melikhov-dev commented Apr 15, 2024

Hi! v6.11.1 and v6.11.2 has some fixes:

[Fix] parse: Fix parsing when the global Object prototype is frozen
[Fix] stringify: encode comma values more consistently

https://github.com/ljharb/qs/blob/main/CHANGELOG.md#6112

@wesleytodd
Copy link
Member

Hey @melikhov-dev, thanks for the PR. Any reason not to just jump to 6.12.1?

@melikhov-dev
Copy link
Author

Hi, @wesleytodd. Just afraid of any new bugs in minor version :) Take a look at this fix last week ljharb/qs#501

@wesleytodd
Copy link
Member

@ljharb any risk you can see with us pulling in the latest and pushing a release including this sometime this week?

@ljharb
Copy link
Contributor

ljharb commented Apr 16, 2024

No; I'd also suggest using ^ since no npm that still can install from the registry is unaware of the carat.

@melikhov-dev bugs happen in all software occasionally; that's what overrides is for :-)

@melikhov-dev
Copy link
Author

@ljharb from my point of view, ^ is better, but I see that all the deps in this package have a fixed or ~ version

@wesleytodd
Copy link
Member

This is a historical thing. The policy in v4 is that express depends on explicit versions for pacakges not owned by the project. There were good reasons for this in the past but I think we will likely move to this for v5. we don't plan to change the existing policy for v4.

So sounds like we can update it, @melikhov-dev can you keep with the hard locked version but bump it to the latest?

@melikhov-dev
Copy link
Author

@wesleytodd ok, i did it

@wesleytodd
Copy link
Member

Ah this error has been happening in all these old CI setups. It isn't because of this PR's changes but because nyc broke in node 8/9. I have a few things I am doing today, but will try to find time to get the CI fixed on this before we merge. Ideally we can get this into the next planned express release we are looking to do this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants