Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Display FCM V1 instructions #27516

Merged
merged 24 commits into from Mar 11, 2024

Conversation

jonsamp
Copy link
Member

@jonsamp jonsamp commented Mar 8, 2024

Why

We are readying the ability to upload FCM V1 credentials to our website. Along with that change, we need to update the docs.

How

This PR:

  • Adds a /push-notifications/fcm-credentials page
  • Updates the credentials part of the setup page (at /push-notifications/push-notifications-setup)
  • Updates other parts of our docs that previously referenced FCM legacy credentials

Screenshots

/push-notifications/fcm-credentials

Add Google Service Account Keys using FCM V1 - Expo Documentation

/push-notifications/push-notifications-setup

Capture-2024-03-07-225633

Test Plan

Read through the docs and make sure they're accurate, and properly explain how to upload and use FCM V1 credentials.

Deployment

This PR should not be merged until we allow the ability to upload FCM V1 credentials on expo.dev.

Copy link

linear bot commented Mar 8, 2024

@jonsamp jonsamp added the preview label Mar 8, 2024
@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Mar 8, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented Mar 8, 2024

📘 Your docs preview website is ready!

docs/pages/push-notifications/fcm-credentials.mdx Outdated Show resolved Hide resolved
docs/pages/push-notifications/fcm-credentials.mdx Outdated Show resolved Hide resolved
docs/pages/push-notifications/fcm-credentials.mdx Outdated Show resolved Hide resolved
docs/pages/push-notifications/fcm-credentials.mdx Outdated Show resolved Hide resolved
docs/pages/push-notifications/fcm-credentials.mdx Outdated Show resolved Hide resolved
docs/pages/push-notifications/fcm-credentials.mdx Outdated Show resolved Hide resolved
docs/pages/push-notifications/fcm-credentials.mdx Outdated Show resolved Hide resolved
docs/pages/push-notifications/fcm-credentials.mdx Outdated Show resolved Hide resolved
docs/pages/push-notifications/fcm-credentials.mdx Outdated Show resolved Hide resolved
docs/pages/push-notifications/push-notifications-setup.mdx Outdated Show resolved Hide resolved
jonsamp and others added 17 commits March 8, 2024 09:45
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
@quinlanj quinlanj self-requested a review March 8, 2024 18:50
jonsamp and others added 3 commits March 11, 2024 09:56
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
@christopherwalter christopherwalter merged commit 7616c4a into main Mar 11, 2024
5 checks passed
@christopherwalter christopherwalter deleted the jon/eng-11640-add-fcm-v1-credential-doc branch March 11, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants