Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKETCH: Drop build constraints for python 3.9+ #13215

Draft
wants to merge 1 commit into
base: v4
Choose a base branch
from

Conversation

adrianeboyd
Copy link
Contributor

Description

The use of build-constraints.txt is an explosion-internal design intertwined with wheelwright. After dropping python 3.8, the oldest-supported-numpy-ish build constraints are no longer necessary, which greatly simplifies the cibuildwheel setup, making it much more feasible/sensible to move wheel building into a repo-internal workflow rather than using wheelwright.

All of the complicated settings related to PIP_CONSTRAINT can be removed from the cibuildwheel settings and you can switch to the build frontend to have more isolated builds. (I thought this would eliminate the need for the clean step for profiling-free python 3.12 builds, but it didn't seem to work in my initial tests.)

wheelwright sketch:

https://github.com/explosion/wheelwright/tree/branch-for-spacy-3899e82e6

ec2buildwheel sketch:

https://github.com/explosion/ec2buildwheel/tree/drop-build-constraints

Resulting wheelwright build:

https://dev.azure.com/explosion-ai/Public/_build/results?buildId=26889&view=results

Types of change

?

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd adrianeboyd marked this pull request as draft December 28, 2023 13:44
@svlandeg svlandeg added the meta Meta topics, e.g. repo organisation and issue management label Jan 18, 2024
@svlandeg svlandeg changed the base branch from master to main January 29, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Meta topics, e.g. repo organisation and issue management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants