SKETCH: Drop build constraints for python 3.9+ #13215
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The use of
build-constraints.txt
is an explosion-internal design intertwined withwheelwright
. After dropping python 3.8, theoldest-supported-numpy
-ish build constraints are no longer necessary, which greatly simplifies thecibuildwheel
setup, making it much more feasible/sensible to move wheel building into a repo-internal workflow rather than usingwheelwright
.All of the complicated settings related to
PIP_CONSTRAINT
can be removed from thecibuildwheel
settings and you can switch to thebuild
frontend to have more isolated builds. (I thought this would eliminate the need for theclean
step for profiling-free python 3.12 builds, but it didn't seem to work in my initial tests.)wheelwright
sketch:https://github.com/explosion/wheelwright/tree/branch-for-spacy-3899e82e6
ec2buildwheel
sketch:https://github.com/explosion/ec2buildwheel/tree/drop-build-constraints
Resulting
wheelwright
build:https://dev.azure.com/explosion-ai/Public/_build/results?buildId=26889&view=results
Types of change
?
Checklist