Remove debug data normalization for span analysis #13203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a result of this normalization, `debug data` could show a user tokens that do not exist in their data.
|
I don't really like it, but I don't know whether the lowercasing is something that's typically used in related work. We can at least remove the confusing quote normalization. Not that it really matters that much either way... |
adrianeboyd
commented
Dec 20, 2023
|
Yea I think it makes sense to remove the quote normalization. |
svlandeg
approved these changes
Jan 29, 2024
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
Mar 14, 2024
* Remove debug data normalization for span analysis As a result of this normalization, `debug data` could show a user tokens that do not exist in their data. * Update spacy/cli/debug_data.py --------- Co-authored-by: svlandeg <svlandeg@github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
Mar 14, 2024
* Remove debug data normalization for span analysis As a result of this normalization, `debug data` could show a user tokens that do not exist in their data. * Update spacy/cli/debug_data.py --------- Co-authored-by: svlandeg <svlandeg@github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
Mar 29, 2024
* Remove debug data normalization for span analysis As a result of this normalization, `debug data` could show a user tokens that do not exist in their data. * Update spacy/cli/debug_data.py --------- Co-authored-by: svlandeg <svlandeg@github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
Apr 17, 2024
* Remove debug data normalization for span analysis As a result of this normalization, `debug data` could show a user tokens that do not exist in their data. * Update spacy/cli/debug_data.py --------- Co-authored-by: svlandeg <svlandeg@github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 10, 2024
* Remove debug data normalization for span analysis As a result of this normalization, `debug data` could show a user tokens that do not exist in their data. * Update spacy/cli/debug_data.py --------- Co-authored-by: svlandeg <svlandeg@github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 10, 2024
* Remove debug data normalization for span analysis As a result of this normalization, `debug data` could show a user tokens that do not exist in their data. * Update spacy/cli/debug_data.py --------- Co-authored-by: svlandeg <svlandeg@github.com>
jordankanter
pushed a commit
to jordankanter/spaCy
that referenced
this pull request
May 21, 2024
* Remove debug data normalization for span analysis As a result of this normalization, `debug data` could show a user tokens that do not exist in their data. * Update spacy/cli/debug_data.py --------- Co-authored-by: svlandeg <svlandeg@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a result of this normalization,
debug datacould show a user tokens that do not exist in their data.Types of change
?
Checklist