Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note in docs on score_weight config if using a non-default spans_key for SpanCat #13093

Merged
merged 6 commits into from
Oct 30, 2023
Merged

Add note in docs on score_weight config if using a non-default spans_key for SpanCat #13093

merged 6 commits into from
Oct 30, 2023

Conversation

rmitsch
Copy link
Contributor

@rmitsch rmitsch commented Oct 30, 2023 •
edited

Description

Add note on score_weight config if using a non-default span_key for SpanCat. Motivated by #13090.

Types of change

Docs improvement.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@rmitsch rmitsch added docs Documentation and website feat / spancat Feature: Span Categorizer labels Oct 30, 2023
@rmitsch rmitsch self-assigned this Oct 30, 2023
@rmitsch rmitsch changed the title Add note on score_weight config if using a non-default span_key for SpanCat Add note in docs on score_weight config if using a non-default span_key for SpanCat Oct 30, 2023
@rmitsch rmitsch changed the title Add note in docs on score_weight config if using a non-default span_key for SpanCat Add note in docs on score_weight config if using a non-default spans_key for SpanCat Oct 30, 2023
shadeMe
shadeMe reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@shadeMe shadeMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one minor comment.

website/docs/api/spancategorizer.mdx Outdated Show resolved Hide resolved
@rmitsch rmitsch merged commit 9deaac9 into explosion:master Oct 30, 2023
4 checks passed
rmitsch added a commit that referenced this pull request Oct 30, 2023
@rmitsch
Add note in docs on score_weight config if using a non-default `spa…
2492b0e 
…ns_key` for SpanCat (#13093)

* Add note on score_weight if using a non-default span_key for SpanCat.

* Fix formatting.

* Fix formatting.

* Fix typo.

* Use warning infobox.

* Fix infobox formatting.

(cherry picked from commit 9deaac9)
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request Mar 14, 2024
@rmitsch @jordankanter
Add note in docs on score_weight config if using a non-default `spa…
fb19c53 
…ns_key` for SpanCat (explosion#13093)

* Add note on score_weight if using a non-default span_key for SpanCat.

* Fix formatting.

* Fix formatting.

* Fix typo.

* Use warning infobox.

* Fix infobox formatting.
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request Mar 29, 2024
@rmitsch @jikanter
Add note in docs on score_weight config if using a non-default `spa…
64bad1c 
…ns_key` for SpanCat (explosion#13093)

* Add note on score_weight if using a non-default span_key for SpanCat.

* Fix formatting.

* Fix formatting.

* Fix typo.

* Use warning infobox.

* Fix infobox formatting.
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request Apr 17, 2024
@rmitsch @jikanter
Add note in docs on score_weight config if using a non-default `spa…
fb94100 
…ns_key` for SpanCat (explosion#13093)

* Add note on score_weight if using a non-default span_key for SpanCat.

* Fix formatting.

* Fix formatting.

* Fix typo.

* Use warning infobox.

* Fix infobox formatting.
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request May 10, 2024
@rmitsch @jikanter
Add note in docs on score_weight config if using a non-default `spa…
5e87ad6 
…ns_key` for SpanCat (explosion#13093)

* Add note on score_weight if using a non-default span_key for SpanCat.

* Fix formatting.

* Fix formatting.

* Fix typo.

* Use warning infobox.

* Fix infobox formatting.
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request May 21, 2024
@rmitsch @jikanter
Add note in docs on score_weight config if using a non-default `spa…
791602c 
…ns_key` for SpanCat (explosion#13093)

* Add note on score_weight if using a non-default span_key for SpanCat.

* Fix formatting.

* Fix formatting.

* Fix typo.

* Use warning infobox.

* Fix infobox formatting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadeMe shadeMe shadeMe approved these changes

Assignees

@rmitsch rmitsch

Labels
docs Documentation and website feat / spancat Feature: Span Categorizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmitsch @shadeMe