Modify EL batching to doc-wise streaming approach #12367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p from Iterable[Span].
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
…o refactor/el-candidates
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
…ntions # Conflicts: # spacy/ml/models/entity_linker.py # website/docs/api/inmemorylookupkb.mdx
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
rmitsch
added
🔜 v4.0
# Conflicts: # spacy/pipeline/entity_linker.py # website/docs/api/entitylinker.mdx
Co-authored-by: Madeesh Kannan <shadeMe@users.noreply.github.com>
svlandeg
reviewed
Feb 6, 2024
spacy/kb/kb.pyx
Outdated
| @@ -30,26 +30,15 @@ cdef class KnowledgeBase: | |||
| self.entity_vector_length = entity_vector_length | |||
| self.mem = Pool() | |||
|
|
|||
| def get_candidates_batch(self, mentions: SpanGroup) -> Iterable[Iterable[Candidate]]: | |||
| def get_candidates(self, mentions: Iterator[SpanGroup]) -> Iterator[Iterable[Iterable[Candidate]]]: | |||
| """ | |||
| Return candidate entities for a specified Span mention. Each candidate defines at least the entity and the | |||
There was a problem hiding this comment.
This still requires updating - the text refers to a single specified Span Mention.
…ch/spaCy into feature/docwise-generator-batching
svlandeg
reviewed
Feb 15, 2024
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
…ch/spaCy into feature/docwise-generator-batching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify EL batching to work doc-based instead of a mention-based. For prior discussion as to why this is useful see #11669 (comment).
Review and merge after #12341.
Split off of #11669.
Types of change
Enhancement.
Checklist