Small update_with_oracle_cut_size fixes
#12314
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldk
added
bug
Fix an off-by-one in `TransitionModel.forward`, where we always did one move more than the maximum number of moves. This explosed another issue: when creating cut states, we skipped states where the (maximum number of) moves from that state only applied transitions that did not modify the buffer. Replace uses of `random.uniform` by `random.randrange`.
danieldk
force-pushed
the
bugfix/max-cut-fixes
branch
from
f9a55e8
to
10f5e94
Compare
danieldk
commented
Feb 21, 2023
svlandeg
added
🔜 v5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an off-by-one in
TransitionModel.forward, where we always did one move more than the maximum number of moves.This explosed another issue: when creating cut states, we skipped states where the (maximum number of) moves from that state only applied transitions that did not modify the buffer.
Replace uses of
random.uniformbyrandom.randrange.Todo: replace remaining uses of
has_gold, since this is more correct.Types of change
Checklist