Meed Layout Editor - Meeds-io/MIPs#120 (#1173) #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, a 'displayTopBarLoading' is initiated by application without a corresponding 'hideTopBarLoading' to stop loading effect. This change will delete the display of page global loading effect and rely instead of the internal loading effect added inside the application while loading the news list.
…eeds-io/MIPs#120 Before this change, some errors are logged in Layout management UI when adding and removing the News List application multiple times. This change ensures to delete listeners on unmount and to make sure that the settings drawer is displayed even in a sticky container.
|
boubaker
changed the title
rdenarie
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Meeds-io/MIPs#120