Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delete Useless Loading Effetct - Meeds-io/MIPs#120 #1173

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

boubaker
Copy link
Member

Prior to this change, a displayTopBarLoading is initiated by application without a corresponding hideTopBarLoading to stop loading effect. This change will delete the display of page global loading effect and rely instead of the internal loading effect added inside the application while loading the news list.

Prior to this change, a 'displayTopBarLoading' is initiated by application without a corresponding 'hideTopBarLoading' to stop loading effect. This change will delete the display of page global loading effect and rely instead of the internal loading effect added inside the application while loading the news list.
@boubaker boubaker merged commit 7175338 into feature/mips Apr 25, 2024
4 checks passed
@boubaker boubaker deleted the meed-mip-120 branch April 25, 2024 15:50
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

boubaker added a commit that referenced this pull request Apr 25, 2024
Prior to this change, a 'displayTopBarLoading' is initiated by application without a corresponding 'hideTopBarLoading' to stop loading effect. This change will delete the display of page global loading effect and rely instead of the internal loading effect added inside the application while loading the news list.
rdenarie pushed a commit that referenced this pull request Apr 26, 2024
Prior to this change, a 'displayTopBarLoading' is initiated by application without a corresponding 'hideTopBarLoading' to stop loading effect. This change will delete the display of page global loading effect and rely instead of the internal loading effect added inside the application while loading the news list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant