fix: Enable to open a file containing an '+' character in its title in the chat application - EXO-64326 #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdenarie
force-pushed
the
feature/maintenance
branch
from
df1a041
to
a23e3a9
Compare
ahamdi
reviewed
May 16, 2023
| @@ -188,6 +189,8 @@ public Response persistFile(@Context SecurityContext securityContext, | |||
| String workspace = node.getSession().getWorkspace().getName(); | |||
| String repository = ((ManageableRepository) node.getSession().getRepository()).getConfiguration().getName(); | |||
| String nodePathWithWorkspace = workspace + node.getPath(); | |||
| String fileNameFromPath = node.getPath().substring(node.getPath().lastIndexOf("/") + 1); | |||
There was a problem hiding this comment.
Why don't we use node.getName() or if the node title exists, node.getProperty("exo:title").getString() ?
sofyenne
force-pushed
the
Task/64326
branch
3 times, most recently
from
86274c6
to
e402e51
Compare
|
Your PR triggers too many exo-ci builds! Please finish your work and then, set your PR ready! Thank you |
exo-swf
force-pushed
the
feature/maintenance
branch
from
a23e3a9
to
ab0e7b9
Compare
…n the chat application - EXO-64326
exo-swf
force-pushed
the
feature/maintenance
branch
from
ab0e7b9
to
67a5b0b
Compare
ahamdi
previously approved these changes
May 23, 2023
exo-swf
force-pushed
the
feature/maintenance
branch
from
67a5b0b
to
5384e4b
Compare
|
Kudos, SonarCloud Quality Gate passed! |
ahamdi
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before to this change , after uploading a file with name containing a '+' character in chat application ,we were unable to open it , the problem that was the '+' character on the file's path being replaced by a space .
After encoding the node name , This change is going to clean the file name using the utils clean name method.