Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image alternate text: single sentence per line #2179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kotp
Copy link
Member

@kotp kotp commented Jan 9, 2023

Noticed image alternative text not being "Single Sentence per Line" for proposed addition to TCL track.

Inspiration: exercism/tcl#267

@glennj
Copy link
Contributor

glennj commented Jan 10, 2023

@SleeplessByte Are there a11y guidelines about such length alt text? I notice the text refers to some numbers being "red".

@SleeplessByte
Copy link
Member

The red mention is extraneous because there is only one type of highlighting. In general you want alt to be as concise as possible, only mentioning relevant information.

These graphics are incredibly information dense. I think the alt text given (except for the red mention) are very good for allowing me to close my eyes and pretending I can't see or can't see well and make a mental map and model of the grid.

I would say that in this particular case it's a really good alt text.

The alternative would be to build this as a table element with the appropriate th for indices, and highlighting in aria labels, bit that's not possible with Markdown, thus this is the accessible option we have.

@SleeplessByte
Copy link
Member

A good test for yourself would be:

How would you explain what you see on the screen as quickly as possible to someone who is on the phone?

Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is purely a whitespace change; no text has been changed.

(One can argue that the word "followings" should be changed to "following", but then this would no longer purely be a whitespace change, so it should be separately)

@kytrinyx
Copy link
Member

Does anyone know if the markdown renders correctly when alt text has multiple lines? I have a vague recollection of having had trouble with something similar at some point, but I cannot for the life of me remember the details.

@SleeplessByte
Copy link
Member

@kytrinyx at least in GFM it is no issue:

long alt text, sentence per newline works in github flavored markdown

@BethanyG BethanyG self-requested a review June 29, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants