Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional (optional) company fields in invoice #37

Closed
wants to merge 4 commits into from

Conversation

zaibacu
Copy link

@zaibacu zaibacu commented Mar 22, 2024

For our use case, Company Code and bank IBAN is required. Since company info is taken from hash instead of array, added these two additional fields

@excid3
Copy link
Owner

excid3 commented Mar 22, 2024

You can create a class that inherits from Invoice and adds this functionality without having to modify the gem.

@zaibacu
Copy link
Author

zaibacu commented Mar 23, 2024

Yes, I have no problem extending it. Just assumed this is quite common requirement for invoice 🙂

@zaibacu zaibacu closed this Mar 23, 2024
@excid3
Copy link
Owner

excid3 commented Mar 25, 2024

I think we can extract a company_details feature to make this customizable through initialize as well so you don't have to override and it would be more flexible.

I can probably put together a PR for that today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants