bump: Bumping unzipper to mitigate license issue #2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unzipper patched a license issue in the 0.11.x version (related issue: ZJONSSON/node-unzipper#293). The full diff of this new minor is avilable at: https://app.renovatebot.com/package-diff?name=unzipper&from=0.10.14&to=0.11.2. With that PR, I only make sure that exceljs will pull or at least allow users to pull the patched version of unzipper. Fixes exceljs#2743
dubzzz
changed the title
|
I realized from the diffs that the |
|
Also I bumped tap to a version that doesn't support node 10. If exceljs needs to support node 10 I will downgrade tap back to the maximum version that works for v10 |
|
I downgraded tap on unzipper master to ensure that the tests match the exceljs test suite. No version bump required as this is only a downgrade of dev dependency |
|
cc @Siemienik, you seem to be the only active maintainer, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unzipper patched a license issue in the 0.11.x version (related issue: ZJONSSON/node-unzipper#293). The full diff of this new minor is avilable at: https://app.renovatebot.com/package-diff?name=unzipper&from=0.10.14&to=0.11.2.
With that PR, I only make sure that exceljs will pull or at least allow users to pull the patched version of unzipper.
Fixes #2743
Test plan
Not applicable
Related to source code (for typings update)
Not applicable