Fix 'unsafe-eval' CSP issue #2672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
commented
Jan 26, 2024
| @@ -53,8 +53,6 @@ spec/integration/data/gold | |||
| /spec/manual/public/exceljs.js | |||
| /spec/manual/public/exceljs.min.js | |||
|
|
|||
| package-lock.json | |||
There was a problem hiding this comment.
patch-package requires package-lock to work. I can extract this to a separate PR if necessary
cherniavskii
commented
Jan 26, 2024
Comment on lines
+9
to
+12
| - // Callback can either be a function or a string | ||
| - if (typeof callback !== "function") { | ||
| - callback = new Function("" + callback); | ||
| - } |
There was a problem hiding this comment.
We never pass a string to setImmediate, so it's safe to remove.
The changes below in jszip.min.js are the same, but the diff looks weird because it's a single-line file 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #713
See #713 (comment) for explanation.
I've used
patch-packageto patch thejszipdependency that is usingnew Function()that violates CSP rules.The new build of exceljs doesn't include the
new Function()anymore.Test plan
I'll prepare before/after demos later as it's tricky to do with Codesandbox/Stackblitz
Related to source code (for typings update)