add: add color field in data bar cf in typescript #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working with the Databar feature in Conditional formating (cf), I encountered an issue related to the color property in TypeScript typings.
Purpose of Change
I identified a deficiency in the existing TypeScript typings for the Databar feature in conditional formatting. The current Databar interface lacks a 'color' type, which is essential for specifying colors within the Databar. This gap in the typings prevents developers from accurately representing and utilizing color settings in Databar conditions.
Changes Made
I have made a targeted change to the TypeScript type file associated with the Databar interface. Specifically, I introduced the 'color' type, which aligns with the functionality of assigning colors in Databar conditions.
Details
Issue Faced: The absence of the 'color' type in the Databar interface impairs the ability to set colors for Databar conditions in conditional formatting.
Solution Proposed: Addition of the 'color' type to the Databar interface in the TypeScript type file.
Testing
I have conducted thorough testing to ensure that the introduced 'color' type integrates seamlessly with the Databar feature and does not introduce any regressions.
Related to Source Code (for typings update)
I made a change in the TypeScript type file, specifically in the Databar interface, to address the color property's absence, enabling developers to utilize color settings in Databar conditions effectively.