Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request to bump version of unzipper to eliminate license concerns #2743

Open
k0s15 opened this issue Apr 15, 2024 · 0 comments · May be fixed by #2744
Open

Request to bump version of unzipper to eliminate license concerns #2743

k0s15 opened this issue Apr 15, 2024 · 0 comments · May be fixed by #2744

Comments

@k0s15
Copy link

k0s15 commented Apr 15, 2024

Unzipper itself has released latest version 0.11.2 which remove the dependency on buffers
Can exceljs upgrade to use latest version of unzipper, so that we can eliminate the license concerns?

Link related on unzipper:
https://www.npmjs.com/package/unzipper
ZJONSSON/node-unzipper#283

Post related on license concerns:
#2703
#2687
#2686
dubzzz added a commit to dubzzz/exceljs that referenced this issue Apr 15, 2024
@dubzzz
bump: Bumping unzipper
34866c3 
Unzipper patched a license issue in the 0.11.x version (related issue: ZJONSSON/node-unzipper#293). The full diff of this new minor is avilable at: https://app.renovatebot.com/package-diff?name=unzipper&from=0.10.14&to=0.11.2.

With that PR, I only make sure that exceljs will pull or at least allow users to pull the patched version of unzipper.

Fixes exceljs#2743
@dubzzz dubzzz linked a pull request Apr 15, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump: Bumping unzipper to mitigate license issue dubzzz/exceljs
1 participant
@k0s15