Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic Slices #544

Merged
merged 7 commits into from Feb 25, 2024
Merged

Generic Slices #544

merged 7 commits into from Feb 25, 2024

Conversation

pakaelbling
Copy link
Contributor

Part of compatibility with other projects, this pull request generalizes slices from int fields to unrestricted generic fields. Fields are checked for compatibility with existing methods (adjust_indices) before use to prevent type errors.

Copy link

cla-bot bot commented Feb 20, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: pakaelbling.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Feb 20, 2024

Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @pakaelbling on file. In order for us to review and merge your code, please email info@exaloop.io to get yourself added.

@arshajii
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Feb 20, 2024
Copy link

cla-bot bot commented Feb 20, 2024

The cla-bot has been summoned, and re-checked this pull request!

@pakaelbling pakaelbling merged commit 4400e3d into develop Feb 25, 2024
5 checks passed
@pakaelbling pakaelbling deleted the feature/generic_slices branch February 25, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants