Add a pre-commit config to correct style issues #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. We require contributors to agree to our Contributor License Agreement (https://exaloop.io/cla.txt), and we don't have @kurtmckee on file. In order for us to review and merge your code, please email info@exaloop.io to get yourself added. |
|
The CLA has been signed. If this PR is desirable but needs tweaking, please let me know! |
kurtmckee
force-pushed
the
add-pre-commit-config
branch
from
8b91f5e
to
3bb3084
Compare
|
Rebased on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a pre-commit config so that file changes are linted and fixed (including running clang-format) prior to committing changes.
During development, developers can install pre-commit (the tool) and then install the git pre-commit hook by running
pre-commit installin the cloned codon directory. Then, before git commits changes, it will automatically run pre-commit (the tool) which will run all of the configured hooks.NOTE: If this merges, I strongly recommend setting up pre-commit.ci to auto-fix incoming PRs if there are style issues, and to keep the pre-commit hooks up-to-date.